Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrabble is a trademark name. #1575

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Scrabble is a trademark name. #1575

merged 1 commit into from
Aug 27, 2019

Conversation

kotp
Copy link
Member

@kotp kotp commented Aug 26, 2019

It should be capitalized. It is also a noun, meaning a "doodle", and a verb, such as what this description could be considered.

In our case, we are referring to the trademarked name of the game Scrabble.

@kotp kotp requested a review from emcoding August 26, 2019 19:15
@kotp
Copy link
Member Author

kotp commented Aug 27, 2019

It was suggested that this change is good, but perhaps a little bit subtle. Should we mention that Scrabble is a game, or is the description suitably vague to encourage just a little bit of research?

@petertseng
Copy link
Member

Then, you may also like to change some other instances of the uncapitalised word "scrabble".

exercises/etl/canonical-data.json:        "Transforms a set of legacy scrabble data stored as letters per score",
exercises/etl/description.md:We're going to extract some scrabble scores from a legacy system.
exercises/etl/description.md:The shiny new scrabble system instead stores the score per letter, which
exercises/scrabble-score/description.md:Given a word, compute the scrabble score for that word.
exercises/scrabble-score/metadata.yml:blurb: "Given a word, compute the scrabble score for that word."

of course, choosing not to do so wouldn't be grounds for refusing this PR, it would just be an indication that perhaps there is more work to be done.

@kotp kotp force-pushed the scrabble-proper-name branch from fb18b66 to d9e9cca Compare August 27, 2019 02:22
@kotp
Copy link
Member Author

kotp commented Aug 27, 2019

Good idea, keeps it in line with the PR, and appropriate.

@kotp kotp requested a review from rpottsoh August 27, 2019 02:23
@kotp kotp self-assigned this Aug 27, 2019
Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change the exercise name in the canonical-data.json “exercise” field. Several other exercises have proper names in that field (armstrong-numbers and pascal-triangle for example) and there’s no sense settings the precedent for a corporate trademark over a human person’s name. Plus this is used to map to a directory on the file system in at least one script I can think of, so this would end up forcing brittle case comparison and could cause real problems with case-sensitive file systems.

@kotp
Copy link
Member Author

kotp commented Aug 27, 2019

We should not change the exercise name in the canonical-data.json “exercise” field. Several other exercises have proper name’s in that field (armstrong-numbers and pascal-triangle for example) and there’s no sense settings the precedent for a corporate trademark over a human person’s name. Plus this is used to map to a directory on the file system in at least one script I can think of, so this would end up forcing brittle case comparison and could cause real problems with case-sensitive file systems.

I was thinking it might be "sensitive". Thanks for the confirmation.

@kotp kotp force-pushed the scrabble-proper-name branch from d9e9cca to 8621cfd Compare August 27, 2019 02:54
@joshgoebel
Copy link
Contributor

I think the changes elsewhere are good. It's a proper noun if nothing else, hence deserving of caps.

@rpottsoh
Copy link
Member

Versioning on json is blocking.

Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is now no substantive change to the canonical-data.json file could that be removed from the PR rather than have a whitespace-only change?

@kotp kotp force-pushed the scrabble-proper-name branch 2 times, most recently from 7a389a3 to 5bbf827 Compare August 27, 2019 03:15
@kotp kotp requested a review from yawpitch August 27, 2019 03:20
Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I believe this repo is still “locked” (see #1560) and this isn’t technically a bug fix change, but it’s now non-impactful and con-controversial, so should be okay to merge.

@kotp kotp force-pushed the scrabble-proper-name branch from 5bbf827 to a938d89 Compare August 27, 2019 03:33
It should be capitalized.  It is also a noun, meaning a "doodle", and a verb, such as what this description could be considered.

In our case, we are referring to the trademarked name of the game Scrabble.

Signed-off-by: Victor Goff <[email protected]>
@kotp kotp force-pushed the scrabble-proper-name branch from a938d89 to ccbce72 Compare August 27, 2019 03:35
@@ -18,8 +18,8 @@
"description": "single letter",
"property": "transform",
"input": {
"legacy": {
"1": ["A"]
"legacy": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, trailing whitespace is making noise... I can make this a separate commit, if anyone is having problems with it being included here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well of course. including a whitespace change in a commit whose commit message mentions Scrabble means that the commit message tells an untruth.

@kotp kotp merged commit 51b8b30 into master Aug 27, 2019
@kotp kotp deleted the scrabble-proper-name branch August 27, 2019 03:43
thalesmg added a commit to thalesmg/haskell that referenced this pull request Oct 12, 2019
It seems that only a version bump is necessary.

Latest changes to this problem:

- exercism/problem-specifications#1536
- exercism/problem-specifications#1575
sshine pushed a commit to exercism/haskell that referenced this pull request Oct 14, 2019
It seems that only a version bump is necessary.

Latest changes to this problem:

- 1.0.0 to 1.0.1, descriptions too long: exercism/problem-specifications#1526
- 1.0.1 to 2.0.0, change input JSON format: exercism/problem-specifications#1536
- 2.0.0 to 2.0.1, capitalize Scrabble: exercism/problem-specifications#1575
sshine pushed a commit to exercism/tcl that referenced this pull request Mar 10, 2020
Bump canonical test version from 2.0.0 to 2.0.1

This addresses exercism/problem-specifications#1575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants